diff options
| author | Stefan Hajnoczi | 2017-03-17 11:45:39 +0100 |
|---|---|---|
| committer | Max Reitz | 2017-03-27 16:50:36 +0200 |
| commit | 4581c16fce3c1078351f3424208f346b11b378f0 (patch) | |
| tree | 0c021c9186f0b319aeebcea3a0b65345908dd6ee /qemu-img.c | |
| parent | Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' int... (diff) | |
| download | qemu-4581c16fce3c1078351f3424208f346b11b378f0.tar.gz qemu-4581c16fce3c1078351f3424208f346b11b378f0.tar.xz qemu-4581c16fce3c1078351f3424208f346b11b378f0.zip | |
qemu-img: show help for invalid global options
The qemu-img sub-command executes regardless of invalid global options:
$ qemu-img --foo info test.img
qemu-img: unrecognized option '--foo'
image: test.img
...
The unrecognized option warning may be missed by the user. This can
hide incorrect command-lines in scripts and confuse users.
This patch prints the help information and terminates instead of
executing the sub-command.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20170317104541.28979-2-stefanha@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qemu-img.c')
| -rw-r--r-- | qemu-img.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/qemu-img.c b/qemu-img.c index 98b836b030..ce293a4710 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4339,6 +4339,7 @@ int main(int argc, char **argv) while ((c = getopt_long(argc, argv, "+hVT:", long_options, NULL)) != -1) { switch (c) { case 'h': + case '?': help(); return 0; case 'V': |