diff options
| author | Max Reitz | 2020-01-21 16:59:14 +0100 |
|---|---|---|
| committer | Max Reitz | 2020-02-20 16:43:42 +0100 |
| commit | c69291e712ae4ef95f628424db6586473da61d43 (patch) | |
| tree | 3fe0ab0a4a164126771be606da85a88b75a44b18 /qemu-img.c | |
| parent | iotests: Add test for image creation fallback (diff) | |
| download | qemu-c69291e712ae4ef95f628424db6586473da61d43.tar.gz qemu-c69291e712ae4ef95f628424db6586473da61d43.tar.xz qemu-c69291e712ae4ef95f628424db6586473da61d43.zip | |
qemu-img: Fix convert -n -B for backing-less targets
s.target_has_backing does not reflect whether the target BDS has a
backing file; it only tells whether we should use a backing file during
conversion (specified by -B).
As such, if you use convert -n, the target does not necessarily actually
have a backing file, and then dereferencing out_bs->backing fails here.
When converting to an existing file, we should set
target_backing_sectors to a negative value, because first, as the
comment explains, this value is only used for optimization, so it is
always fine to do that.
Second, we use this value to determine where the target must be
initialized to zeroes (overlays are initialized to zero after the end of
their backing file). When converting to an existing file, we cannot
assume that to be true.
Cc: qemu-stable@nongnu.org
Fixes: 351c8efff9ad809c822d55620df54d575d536f68
("qemu-img: Special post-backing convert handling")
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200121155915.98232-2-mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qemu-img.c')
| -rw-r--r-- | qemu-img.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/qemu-img.c b/qemu-img.c index 0faf2cd2f5..804630a368 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -2523,7 +2523,7 @@ static int img_convert(int argc, char **argv) } } - if (s.target_has_backing) { + if (s.target_has_backing && s.target_is_new) { /* Errors are treated as "backing length unknown" (which means * s.target_backing_sectors has to be negative, which it will * be automatically). The backing file length is used only |