diff options
| author | Yanan Wang | 2021-09-28 14:11:34 +0200 |
|---|---|---|
| committer | Laurent Vivier | 2021-10-04 09:47:26 +0200 |
| commit | 848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd (patch) | |
| tree | bb3fa212a6238b097d42f45f488892a67994cdeb /qemu-options.hx | |
| parent | qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] (diff) | |
| download | qemu-848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd.tar.gz qemu-848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd.tar.xz qemu-848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd.zip | |
qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2"
There is one numa config example in qemu-options.hx currently
using "-smp 2" and assuming that there will be 2 sockets and
2 cpus totally. However now the actual calculation logic of
missing sockets and cores is not immutable and is considered
liable to change. Although we will get maxcpus=2 finally based
on current parser, it's always stable to specify it explicitly.
So "-smp 2,sockets=2,maxcpus=2" will be optimal when we expect
multiple sockets and 2 cpus totally.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Message-Id: <20210928121134.21064-3-wangyanan55@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'qemu-options.hx')
| -rw-r--r-- | qemu-options.hx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/qemu-options.hx b/qemu-options.hx index bba1ef973f..5f375bbfa6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -401,7 +401,7 @@ SRST -m 2G \ -object memory-backend-ram,size=1G,id=m0 \ -object memory-backend-ram,size=1G,id=m1 \ - -smp 2 \ + -smp 2,sockets=2,maxcpus=2 \ -numa node,nodeid=0,memdev=m0 \ -numa node,nodeid=1,memdev=m1,initiator=0 \ -numa cpu,node-id=0,socket-id=0 \ |