diff options
| author | Philippe Mathieu-Daudé | 2020-01-21 12:03:45 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2020-01-24 20:59:11 +0100 |
| commit | 89d337fdd207a378df55a5811347b31bca83e117 (patch) | |
| tree | e71d64a2171a65efc4033446cdffe0d0bd9ca1ed /qom | |
| parent | target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported() (diff) | |
| download | qemu-89d337fdd207a378df55a5811347b31bca83e117.tar.gz qemu-89d337fdd207a378df55a5811347b31bca83e117.tar.xz qemu-89d337fdd207a378df55a5811347b31bca83e117.zip | |
qom/object: Display more helpful message when a parent is missing
QEMU object model is scarse in documentation. Some calls are
recursive, and it might be hard to figure out even trivial issues.
We can avoid developers to waste time in a debugging session by
displaying a simple error message.
This commit is also similar to e02bdf1cecd2 ("Display more helpful
message when an object type is missing").
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200121110349.25842-7-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'qom')
| -rw-r--r-- | qom/object.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/qom/object.c b/qom/object.c index 36123fb330..90155faec1 100644 --- a/qom/object.c +++ b/qom/object.c @@ -173,7 +173,11 @@ static TypeImpl *type_get_parent(TypeImpl *type) { if (!type->parent_type && type->parent) { type->parent_type = type_get_by_name(type->parent); - g_assert(type->parent_type != NULL); + if (!type->parent_type) { + fprintf(stderr, "Type '%s' is missing its parent '%s'\n", + type->name, type->parent); + abort(); + } } return type->parent_type; |