diff options
| author | Daniel P. Berrangé | 2021-02-04 13:48:23 +0100 |
|---|---|---|
| committer | Dr. David Alan Gilbert | 2021-02-08 12:19:51 +0100 |
| commit | e26f98e2097cf17db04462e9aa2e423b93e7455c (patch) | |
| tree | c2483a9aa4721a8073b8e28d2a4b1b3e2b465f50 /replay | |
| parent | migration: Display the migration blockers (diff) | |
| download | qemu-e26f98e2097cf17db04462e9aa2e423b93e7455c.tar.gz qemu-e26f98e2097cf17db04462e9aa2e423b93e7455c.tar.xz qemu-e26f98e2097cf17db04462e9aa2e423b93e7455c.zip | |
block: push error reporting into bdrv_all_*_snapshot functions
The bdrv_all_*_snapshot functions return a BlockDriverState pointer
for the invalid backend, which the callers then use to report an
error message. In some cases multiple callers are reporting the
same error message, but with slightly different text. In the future
there will be more error scenarios for some of these methods, which
will benefit from fine grained error message reporting. So it is
helpful to push error reporting down a level.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[PMD: Initialize variables]
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210204124834.774401-2-berrange@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'replay')
| -rw-r--r-- | replay/replay-debugging.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c index 5ec574724a..3a9b609e62 100644 --- a/replay/replay-debugging.c +++ b/replay/replay-debugging.c @@ -148,7 +148,7 @@ static char *replay_find_nearest_snapshot(int64_t icount, *snapshot_icount = -1; - bs = bdrv_all_find_vmstate_bs(); + bs = bdrv_all_find_vmstate_bs(NULL); if (!bs) { goto fail; } @@ -159,7 +159,7 @@ static char *replay_find_nearest_snapshot(int64_t icount, aio_context_release(aio_context); for (i = 0; i < nb_sns; i++) { - if (bdrv_all_find_snapshot(sn_tab[i].name, &bs) == 0) { + if (bdrv_all_find_snapshot(sn_tab[i].name, NULL) == 0) { if (sn_tab[i].icount != -1ULL && sn_tab[i].icount <= icount && (!nearest || nearest->icount < sn_tab[i].icount)) { |