diff options
| author | Markus Armbruster | 2015-02-09 14:03:19 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2015-02-18 10:51:28 +0100 |
| commit | 1677f4c66cf2228eb14f1b0571d0e3b38d0d6606 (patch) | |
| tree | 7c103f0cc73fd4c8eb6e8a70483e740377cd4229 /scripts/checkpatch.pl | |
| parent | error: Use error_report_err() where appropriate (diff) | |
| download | qemu-1677f4c66cf2228eb14f1b0571d0e3b38d0d6606.tar.gz qemu-1677f4c66cf2228eb14f1b0571d0e3b38d0d6606.tar.xz qemu-1677f4c66cf2228eb14f1b0571d0e3b38d0d6606.zip | |
monitor: Clean up around monitor_handle_fd_param()
monitor_handle_fd_param() is a wrapper around
monitor_handle_fd_param2() that feeds errors to qerror_report_err()
instead of returning them. qerror_report_err() is inappropriate in
many contexts. monitor_handle_fd_param() looks simpler than
monitor_handle_fd_param2(), which tempts use. Remove the temptation:
drop the wrapper and open-code the (trivial) error handling instead.
Replace the open-coded qerror_report_err() by error_report_err() in
places that already use error_report(). Turns out that's everywhere.
While there, rename monitor_handle_fd_param2() to monitor_fd_param().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'scripts/checkpatch.pl')
0 files changed, 0 insertions, 0 deletions
