diff options
| author | yuchenlin | 2019-02-21 12:08:05 +0100 |
|---|---|---|
| committer | Max Reitz | 2019-02-25 15:11:28 +0100 |
| commit | 26c9296c31bc5d0fab24379af0a1684b099067de (patch) | |
| tree | 3a2e0776369063febff896e6b35c7fcae8645ee5 /scripts/checkpatch.pl | |
| parent | iotests: add LUKS payload overhead to 178 qemu-img measure test (diff) | |
| download | qemu-26c9296c31bc5d0fab24379af0a1684b099067de.tar.gz qemu-26c9296c31bc5d0fab24379af0a1684b099067de.tar.xz qemu-26c9296c31bc5d0fab24379af0a1684b099067de.zip | |
vmdk: false positive of compat6 with hwversion not set
In vmdk_co_create_opts, when it finds hw_version is undefined, it will
set it to 4, which misleading the compat6 and hwversion in
vmdk_co_do_create. Simply set hw_version to NULL after free, let
the logic in vmdk_co_do_create to decide the value of hw_version.
This bug can be reproduced by:
$ qemu-img convert -O vmdk -o subformat=streamOptimized,compat6
/home/yuchenlin/syno.qcow2 /home/yuchenlin/syno.vmdk
qemu-img: /home/yuchenlin/syno.vmdk: error while converting vmdk:
compat6 cannot be enabled with hwversion set
Signed-off-by: yuchenlin <yuchenlin@synology.com>
Message-id: 20190221110805.28239-1-yuchenlin@synology.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'scripts/checkpatch.pl')
0 files changed, 0 insertions, 0 deletions