diff options
| author | Laszlo Ersek | 2013-11-28 18:12:59 +0100 |
|---|---|---|
| committer | Anthony Liguori | 2013-12-17 00:33:48 +0100 |
| commit | f46e720a82ccdf1a521cf459448f3f96ed895d43 (patch) | |
| tree | 7d73a6f642670a82d1d627f07153c577ff71981c /scripts/checkpatch.pl | |
| parent | Merge remote-tracking branch 'spice/tags/pull-spice-1' into staging (diff) | |
| download | qemu-f46e720a82ccdf1a521cf459448f3f96ed895d43.tar.gz qemu-f46e720a82ccdf1a521cf459448f3f96ed895d43.tar.xz qemu-f46e720a82ccdf1a521cf459448f3f96ed895d43.zip | |
qemu_opts_parse(): always check return value
qemu_opts_parse() can always return NULL, even if the QemuOptsList.desc in
question would be trivial to satisfy (eg. because it's empty). For
example:
qemu_opts_parse()
opts_parse()
qemu_opts_create()
id_wellformed()
In practice:
$ .../qemu-system-x86_64 -acpitable id=3
qemu-system-x86_64: -acpitable id=3: Parameter 'id' expects an identifier
**
ERROR:vl.c:3491:main: assertion failed: (opts != NULL)
Aborted (core dumped)
$ .../qemu-system-x86_64 -smbios id=3
qemu-system-x86_64: -smbios id=3: Parameter 'id' expects an identifier
Segmentation fault (core dumped)
I checked all qemu_opts_parse() invocations (and all drive_def()
invocations too, because it blindly forwards the former's retval). Only
the two above examples look problematic.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1385658779-7529-1-git-send-email-lersek@redhat.com
Signed-off-by: Anthony Liguori <aliguori@amazon.com>
Diffstat (limited to 'scripts/checkpatch.pl')
0 files changed, 0 insertions, 0 deletions