diff options
| author | Philippe Mathieu-Daudé | 2020-02-20 11:25:40 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé | 2020-02-20 14:47:08 +0100 |
| commit | 4ef044cb148a5238161310f06bc581aeed70059f (patch) | |
| tree | 98bd540884f6640a2be5dcced871697e556b31a6 /scripts/coccinelle | |
| parent | exec: Let the address_space API use void pointer arguments (diff) | |
| download | qemu-4ef044cb148a5238161310f06bc581aeed70059f.tar.gz qemu-4ef044cb148a5238161310f06bc581aeed70059f.tar.xz qemu-4ef044cb148a5238161310f06bc581aeed70059f.zip | |
hw/net: Avoid casting non-const pointer, use address_space_write()
The NetReceive prototype gets a const buffer:
typedef ssize_t (NetReceive)(NetClientState *, const uint8_t *, size_t);
We already have the address_space_write() method to write a const
buffer to an address space. Use it to avoid:
hw/net/i82596.c: In function ‘i82596_receive’:
hw/net/i82596.c:644:54: error: passing argument 4 of ‘address_space_rw’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
This commit was produced with the included Coccinelle script
scripts/coccinelle/exec_rw_const.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'scripts/coccinelle')
| -rw-r--r-- | scripts/coccinelle/exec_rw_const.cocci | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/scripts/coccinelle/exec_rw_const.cocci b/scripts/coccinelle/exec_rw_const.cocci index 7e42682240..87897dd1b3 100644 --- a/scripts/coccinelle/exec_rw_const.cocci +++ b/scripts/coccinelle/exec_rw_const.cocci @@ -9,6 +9,20 @@ --dir . */ +// Use address_space_write instead of casting to non-const +@@ +type T; +const T *V; +expression E1, E2, E3, E4; +@@ +( +- address_space_rw(E1, E2, E3, (T *)V, E4, 1) ++ address_space_write(E1, E2, E3, V, E4) +| +- address_space_rw(E1, E2, E3, (void *)V, E4, 1) ++ address_space_write(E1, E2, E3, V, E4) +) + // Remove useless cast @@ expression E1, E2, E3, E4; |