diff options
| author | Markus Armbruster | 2017-03-06 20:00:39 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2017-03-07 14:53:28 +0100 |
| commit | 89e2a31d337f96ab8d5b7bdfe4bcce0a25181ed1 (patch) | |
| tree | e32cf2a31e57dfb44aad2c9bf1c71d4ce790ebf3 /scripts/modules | |
| parent | sheepdog: Mark sd_snapshot_delete() lossage FIXME (diff) | |
| download | qemu-89e2a31d337f96ab8d5b7bdfe4bcce0a25181ed1.tar.gz qemu-89e2a31d337f96ab8d5b7bdfe4bcce0a25181ed1.tar.xz qemu-89e2a31d337f96ab8d5b7bdfe4bcce0a25181ed1.zip | |
sheepdog: Fix snapshot ID parsing in _open(), _create, _goto()
sd_parse_uri() and sd_snapshot_goto() screw up error checking after
strtoul(), and truncate long tag names silently. Fix by replacing
those parts by new sd_parse_snapid_or_tag(), which checks more
carefully.
sd_snapshot_delete() also parses snapshot IDs, but is currently too
broken for me to touch. Mark TODO.
Two calls of strtol() without error checking remain in
parse_redundancy(). Mark them FIXME.
More silent truncation of configuration strings remains elsewhere.
Not marked.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'scripts/modules')
0 files changed, 0 insertions, 0 deletions