diff options
| author | Markus Armbruster | 2017-03-06 20:00:36 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2017-03-07 14:53:28 +0100 |
| commit | e25cad6921ef78c8e2b7a4f59b03545bd675a9ad (patch) | |
| tree | 95380ecebe5c10eeb5d0460c9e06cb5b8e85ab39 /scripts/modules | |
| parent | sheepdog: Defuse time bomb in sd_open() error handling (diff) | |
| download | qemu-e25cad6921ef78c8e2b7a4f59b03545bd675a9ad.tar.gz qemu-e25cad6921ef78c8e2b7a4f59b03545bd675a9ad.tar.xz qemu-e25cad6921ef78c8e2b7a4f59b03545bd675a9ad.zip | |
sheepdog: Fix error handling in sd_snapshot_delete()
As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an
error and return negative errno on failure. It sometimes returns -1,
and sometimes neglects to set an error. It also prints error messages
with error_report(). Fix all that.
Moreover, its handling of an attempt to delete a nonexistent snapshot
is wrong: it error_report()s and succeeds. Fix it to set an error and
return -ENOENT instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'scripts/modules')
0 files changed, 0 insertions, 0 deletions
