diff options
| author | Alberto Garcia | 2018-11-12 15:00:43 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2018-12-14 11:55:02 +0100 |
| commit | 3c4e964762c7d0292185473657dd2afc0d2d060b (patch) | |
| tree | 1a68b88c29b924fcb3f1f2102fed3a285ea59c5d /scripts/qapi/doc.py | |
| parent | qemu-io: Put flag changes in the options QDict in reopen_f() (diff) | |
| download | qemu-3c4e964762c7d0292185473657dd2afc0d2d060b.tar.gz qemu-3c4e964762c7d0292185473657dd2afc0d2d060b.tar.xz qemu-3c4e964762c7d0292185473657dd2afc0d2d060b.zip | |
block: Clean up reopen_backing_file() in block/replication.c
This function is used to put the hidden and secondary disks in
read-write mode before launching the backup job, and back in read-only
mode afterwards.
This patch does the following changes:
- Use an options QDict with the "read-only" option instead of
passing the changes as flags only.
- Simplify the code (it was unnecessarily complicated and verbose).
- Fix a bug due to which the secondary disk was not being put back
in read-only mode when writable=false (because in this case
orig_secondary_flags always had the BDRV_O_RDWR flag set).
- Stop clearing the BDRV_O_INACTIVE flag.
The flags parameter to bdrv_reopen_queue() becomes redundant and we'll
be able to get rid of it in a subsequent patch.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'scripts/qapi/doc.py')
0 files changed, 0 insertions, 0 deletions