diff options
| author | Philippe Mathieu-Daudé | 2021-12-15 19:24:19 +0100 |
|---|---|---|
| committer | Peter Maydell | 2022-01-20 17:04:58 +0100 |
| commit | b9d383ab797f54ae5fa8746117770709921dc529 (patch) | |
| tree | 6727727d2953e4122bffacc2715edff3b42346b5 /scripts/qapi/expr.py | |
| parent | hw/intc/arm_gicv3_its: Range-check ICID before indexing into collection table (diff) | |
| download | qemu-b9d383ab797f54ae5fa8746117770709921dc529.tar.gz qemu-b9d383ab797f54ae5fa8746117770709921dc529.tar.xz qemu-b9d383ab797f54ae5fa8746117770709921dc529.zip | |
hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR
Quoting Peter Maydell:
"These MEMTX_* aren't from the memory transaction
API functions; they're just being used by gicd_readl() and
friends as a way to indicate a success/failure so that the
actual MemoryRegionOps read/write fns like gicv3_dist_read()
can log a guest error."
We are going to introduce more MemTxResult bits, so it is
safer to check for !MEMTX_OK rather than MEMTX_ERROR.
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'scripts/qapi/expr.py')
0 files changed, 0 insertions, 0 deletions