diff options
| author | David Hildenbrand | 2021-08-05 11:23:50 +0200 |
|---|---|---|
| committer | Peter Maydell | 2021-08-17 17:51:39 +0200 |
| commit | 1c4c68593610e81fc3ba8d3919ec3fc9f26e063d (patch) | |
| tree | d5e9717c4dd11429e3d2e6cb1094f5623b8e9f56 /scripts/qapi/main.py | |
| parent | qapi/machine.json: Remove zero value reference from SMPConfiguration document... (diff) | |
| download | qemu-1c4c68593610e81fc3ba8d3919ec3fc9f26e063d.tar.gz qemu-1c4c68593610e81fc3ba8d3919ec3fc9f26e063d.tar.xz qemu-1c4c68593610e81fc3ba8d3919ec3fc9f26e063d.zip | |
softmmu/physmem: fix wrong assertion in qemu_ram_alloc_internal()
When adding RAM_NORESERVE, we forgot to remove the old assertion when
adding the updated one, most probably when reworking the patches or
rebasing. We can easily crash QEMU by adding
-object memory-backend-ram,id=mem0,size=500G,reserve=off
to the QEMU cmdline:
qemu-system-x86_64: ../softmmu/physmem.c:2146: qemu_ram_alloc_internal:
Assertion `(ram_flags & ~(RAM_SHARED | RAM_RESIZEABLE | RAM_PREALLOC))
== 0' failed.
Fix it by removing the old assertion.
Fixes: 8dbe22c6868b ("memory: Introduce RAM_NORESERVE and wire it up in qemu_ram_mmap()")
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-id: 20210805092350.31195-1-david@redhat.com
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'scripts/qapi/main.py')
0 files changed, 0 insertions, 0 deletions