summaryrefslogtreecommitdiffstats
path: root/scripts/qapi/schema.py
diff options
context:
space:
mode:
authorMarkus Armbruster2019-10-24 13:02:27 +0200
committerMarkus Armbruster2019-10-29 07:35:16 +0100
commit36a43905ffcac8767947626a6761df63fc020841 (patch)
tree9ff4be99477399d14decad1771588dc67201cde3 /scripts/qapi/schema.py
parentqapi: Split .connect_doc(), .check_doc() off .check() (diff)
downloadqemu-36a43905ffcac8767947626a6761df63fc020841.tar.gz
qemu-36a43905ffcac8767947626a6761df63fc020841.tar.xz
qemu-36a43905ffcac8767947626a6761df63fc020841.zip
qapi: Fix enum doc comment checking
Enumeration type documentation comments are not checked, as demonstrated by test doc-bad-enum-member. This is because we neglect to call self.doc.check() for enumeration types. Messed up in 816a57cd6e "qapi: Fix detection of bogus member documentation". Fix it. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20191024110237.30963-10-armbru@redhat.com>
Diffstat (limited to 'scripts/qapi/schema.py')
-rw-r--r--scripts/qapi/schema.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 9b62c8d74d..0381e3cb40 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -229,6 +229,10 @@ class QAPISchemaEnumType(QAPISchemaType):
for m in self.members:
self.doc.connect_member(m)
+ def check_doc(self):
+ if self.doc:
+ self.doc.check()
+
def is_implicit(self):
# See QAPISchema._make_implicit_enum_type() and ._def_predefineds()
return self.name.endswith('Kind') or self.name == 'QType'