diff options
| author | John Snow | 2020-10-09 18:15:28 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2020-10-10 11:37:47 +0200 |
| commit | 5af8263d40c698c47befd4c0bed3d6c452b56d82 (patch) | |
| tree | 36e92c1264edfd0b64e4d059440a5d66bb78be94 /scripts/qapi/visit.py | |
| parent | qapi: Prefer explicit relative imports (diff) | |
| download | qemu-5af8263d40c698c47befd4c0bed3d6c452b56d82.tar.gz qemu-5af8263d40c698c47befd4c0bed3d6c452b56d82.tar.xz qemu-5af8263d40c698c47befd4c0bed3d6c452b56d82.zip | |
qapi: Remove wildcard includes
Wildcard includes become hard to manage when refactoring and dealing
with circular dependencies with strictly typed mypy.
flake8 also flags each one as a warning, as it is not smart enough to
know which names exist in the imported file.
Remove them and include things explicitly by name instead.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201009161558.107041-7-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts/qapi/visit.py')
| -rw-r--r-- | scripts/qapi/visit.py | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py index 7850f6e848..ea277e7704 100644 --- a/scripts/qapi/visit.py +++ b/scripts/qapi/visit.py @@ -13,7 +13,15 @@ This work is licensed under the terms of the GNU GPL, version 2. See the COPYING file in the top-level directory. """ -from .common import * +from .common import ( + c_enum_const, + c_name, + gen_endif, + gen_if, + mcgen, + pop_indent, + push_indent, +) from .gen import QAPISchemaModularCVisitor, ifcontext from .schema import QAPISchemaObjectType |