diff options
| author | Fam Zheng | 2015-06-08 07:56:10 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2015-07-02 11:06:23 +0200 |
| commit | 508249952c0ea7472c62e17bf8132295dab4912d (patch) | |
| tree | 0097014b93cf0e14fe7208b1c1d2123f3201f07c /scripts/switch-timer-api | |
| parent | mirror: Do zero write on target if sectors not allocated (diff) | |
| download | qemu-508249952c0ea7472c62e17bf8132295dab4912d.tar.gz qemu-508249952c0ea7472c62e17bf8132295dab4912d.tar.xz qemu-508249952c0ea7472c62e17bf8132295dab4912d.zip | |
block: Fix dirty bitmap in bdrv_co_discard
Unsetting dirty globally with discard is not very correct. The discard may zero
out sectors (depending on can_write_zeroes_with_unmap), we should replicate
this change to destination side to make sure that the guest sees the same data.
Calling bdrv_reset_dirty also troubles mirror job because the hbitmap iterator
doesn't expect unsetting of bits after current position.
So let's do it the opposite way which fixes both problems: set the dirty bits
if we are to discard it.
Reported-by: wangxiaolong@ucloud.cn
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'scripts/switch-timer-api')
0 files changed, 0 insertions, 0 deletions
