diff options
| author | Laurent Vivier | 2021-01-05 20:17:21 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2021-02-01 11:50:54 +0100 |
| commit | 9f4e519fd7acbdb027d22e13e4f1cd8e79969dec (patch) | |
| tree | 88e9d5a06c6860e692871a63687167e049e53099 /scripts/tracetool/format | |
| parent | trace: recommend "log" backend for getting started with tracing (diff) | |
| download | qemu-9f4e519fd7acbdb027d22e13e4f1cd8e79969dec.tar.gz qemu-9f4e519fd7acbdb027d22e13e4f1cd8e79969dec.tar.xz qemu-9f4e519fd7acbdb027d22e13e4f1cd8e79969dec.zip | |
tracetool: fix "PRI" macro decoding
macro is not reset after use, so the format decoded is always the
one of the first "PRI" in the format string.
For instance:
vhost_vdpa_set_config(void *dev, uint32_t offset, uint32_t size, \
uint32_t flags) "dev: %p offset: %"PRIu32" \
size: %"PRIu32" flags: 0x%"PRIx32
generates:
printf("%d@%d vhost_vdpa_set_config dev: %p offset: %u size: %u \
flags: 0x%u\n", pid(), gettimeofday_ns(), dev, offset, \
size, flags)
for the "flags" parameter, we can see a "0x%u" rather than a "0x%x"
because the first macro was "PRIu32" (for offset).
In the loop, macro becomes "PRIu32PRIu32PRIx32", and c_macro_to_format()
returns always macro[3] ('u' in this case). This patch resets macro after
the format has been decoded.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20210105191721.120463-3-lvivier@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'scripts/tracetool/format')
| -rw-r--r-- | scripts/tracetool/format/log_stap.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/tracetool/format/log_stap.py b/scripts/tracetool/format/log_stap.py index b486beb672..3e1186ae9c 100644 --- a/scripts/tracetool/format/log_stap.py +++ b/scripts/tracetool/format/log_stap.py @@ -54,6 +54,7 @@ def c_fmt_to_stap(fmt): else: if state == STATE_MACRO: bits.append(c_macro_to_format(macro)) + macro = "" state = STATE_LITERAL elif fmt[i] == ' ' or fmt[i] == '\t': if state == STATE_MACRO: |