diff options
| author | Markus Armbruster | 2018-10-17 10:26:35 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2018-10-19 14:51:34 +0200 |
| commit | 1028283c60e6e35911bb80b959a533b4af1b8b65 (patch) | |
| tree | 392fec3e8109c797cf47c5e21bad4c229f8fadd7 /scripts | |
| parent | ioapic: Fix error handling in realize() (diff) | |
| download | qemu-1028283c60e6e35911bb80b959a533b4af1b8b65.tar.gz qemu-1028283c60e6e35911bb80b959a533b4af1b8b65.tar.xz qemu-1028283c60e6e35911bb80b959a533b4af1b8b65.zip | |
smbios: Clean up error handling in smbios_add()
Calling error_report() in a function that takes an Error ** argument
is suspicious. smbios_entry_add() does that, and then exit()s. It
also passes &error_fatal to qemu_opts_validate(). Both wrong, but
currently harmless, as its only caller passes &error_fatal. Messed up
in commit 1007a37e208. Clean it up.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20181017082702.5581-12-armbru@redhat.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions