diff options
| author | Markus Armbruster | 2017-03-03 13:32:45 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2017-03-05 09:14:20 +0100 |
| commit | a4a1c70dc759e5b81627e96564f344ab43ea86eb (patch) | |
| tree | 56d44358c6e76c57a01aed7ee789b68965dcc2ff /scripts | |
| parent | test-qobject-input-visitor: Cover missing nested struct member (diff) | |
| download | qemu-a4a1c70dc759e5b81627e96564f344ab43ea86eb.tar.gz qemu-a4a1c70dc759e5b81627e96564f344ab43ea86eb.tar.xz qemu-a4a1c70dc759e5b81627e96564f344ab43ea86eb.zip | |
qapi: Make input visitors detect unvisited list tails
Fix the design flaw demonstrated in the previous commit: new method
check_list() lets input visitors report that unvisited input remains
for a list, exactly like check_struct() lets them report that
unvisited input remains for a struct or union.
Implement the method for the qobject input visitor (straightforward),
and the string input visitor (less so, due to the magic list syntax
there). The opts visitor's list magic is even more impenetrable, and
all I can do there today is a stub with a FIXME comment. No worse
than before.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1488544368-30622-26-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/qapi-visit.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 96f2491c16..330b9f321b 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -133,6 +133,9 @@ void visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error } } + if (!err) { + visit_check_list(v, &err); + } visit_end_list(v, (void **)obj); if (err && visit_is_input(v)) { qapi_free_%(c_name)s(*obj); |