diff options
| author | Philippe Mathieu-Daudé | 2020-10-30 16:37:52 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2020-11-03 15:42:52 +0100 |
| commit | 379218511219feddb85fde6362c0eefd94dd4828 (patch) | |
| tree | 8934e990ad5bed1fc3940e176937b6d9641496c7 /softmmu/physmem.c | |
| parent | docs: expand sourceset documentation (diff) | |
| download | qemu-379218511219feddb85fde6362c0eefd94dd4828.tar.gz qemu-379218511219feddb85fde6362c0eefd94dd4828.tar.xz qemu-379218511219feddb85fde6362c0eefd94dd4828.zip | |
exec: Remove dead code (CID 1432876)
We removed the global_locking field in commit 4174495408a,
leaving dead code around the 'unlocked' variable. Remove it
to fix the DEADCODE issue reported by Coverity (CID 1432876).
Fixes: 4174495408a ("exec: Remove MemoryRegion::global_locking field")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201030153752.1557776-1-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'softmmu/physmem.c')
| -rw-r--r-- | softmmu/physmem.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/softmmu/physmem.c b/softmmu/physmem.c index a9adedb9f8..0b31be2928 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2723,22 +2723,14 @@ static int memory_access_size(MemoryRegion *mr, unsigned l, hwaddr addr) static bool prepare_mmio_access(MemoryRegion *mr) { - bool unlocked = !qemu_mutex_iothread_locked(); bool release_lock = false; - if (unlocked) { + if (!qemu_mutex_iothread_locked()) { qemu_mutex_lock_iothread(); - unlocked = false; release_lock = true; } if (mr->flush_coalesced_mmio) { - if (unlocked) { - qemu_mutex_lock_iothread(); - } qemu_flush_coalesced_mmio_buffer(); - if (unlocked) { - qemu_mutex_unlock_iothread(); - } } return release_lock; |