summaryrefslogtreecommitdiffstats
path: root/softmmu
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé2021-12-15 19:24:20 +0100
committerThomas Huth2022-03-21 10:03:30 +0100
commit58e74682baf4e1ad26b064d8c02e5bc99c75c5d9 (patch)
tree9d21ece195234cf0df958a89d21ab7af83be7fd6 /softmmu
parentMerge tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu into sta... (diff)
downloadqemu-58e74682baf4e1ad26b064d8c02e5bc99c75c5d9.tar.gz
qemu-58e74682baf4e1ad26b064d8c02e5bc99c75c5d9.tar.xz
qemu-58e74682baf4e1ad26b064d8c02e5bc99c75c5d9.zip
softmmu/physmem: Simplify flatview_write and address_space_access_valid
Remove unuseful local 'result' variables. Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Alexander Bulekov <alxndr@bu.edu> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20211215182421.418374-3-philmd@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'softmmu')
-rw-r--r--softmmu/physmem.c11
1 files changed, 3 insertions, 8 deletions
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 43ae70fbe2..3d968ca92f 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -2816,14 +2816,11 @@ static MemTxResult flatview_write(FlatView *fv, hwaddr addr, MemTxAttrs attrs,
hwaddr l;
hwaddr addr1;
MemoryRegion *mr;
- MemTxResult result = MEMTX_OK;
l = len;
mr = flatview_translate(fv, addr, &addr1, &l, true, attrs);
- result = flatview_write_continue(fv, addr, attrs, buf, len,
- addr1, l, mr);
-
- return result;
+ return flatview_write_continue(fv, addr, attrs, buf, len,
+ addr1, l, mr);
}
/* Called within RCU critical section. */
@@ -3139,12 +3136,10 @@ bool address_space_access_valid(AddressSpace *as, hwaddr addr,
MemTxAttrs attrs)
{
FlatView *fv;
- bool result;
RCU_READ_LOCK_GUARD();
fv = address_space_to_flatview(as);
- result = flatview_access_valid(fv, addr, len, is_write, attrs);
- return result;
+ return flatview_access_valid(fv, addr, len, is_write, attrs);
}
static hwaddr