diff options
| author | Michal Privoznik | 2022-10-26 09:30:24 +0200 |
|---|---|---|
| committer | Daniel P. Berrangé | 2022-10-26 14:32:58 +0200 |
| commit | 73422d9524376526ab5950b3be3098901cd605d6 (patch) | |
| tree | 9624968f625979d7ea9d0243ca6b6597baf97512 /softmmu | |
| parent | io/channel-watch: Fix socket watch on Windows (diff) | |
| download | qemu-73422d9524376526ab5950b3be3098901cd605d6.tar.gz qemu-73422d9524376526ab5950b3be3098901cd605d6.tar.xz qemu-73422d9524376526ab5950b3be3098901cd605d6.zip | |
seccomp: Get actual errno value from failed seccomp functions
Upon failure, a libseccomp API returns actual errno value very
rarely. Fortunately, after its commit 34bf78ab (contained in
2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribute can be set
which makes subsequent APIs return true errno on failure.
This is especially critical when seccomp_load() fails, because
generic -ECANCELED says nothing.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'softmmu')
| -rw-r--r-- | softmmu/qemu-seccomp.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/softmmu/qemu-seccomp.c b/softmmu/qemu-seccomp.c index deaf8a4ef5..d66a2a1226 100644 --- a/softmmu/qemu-seccomp.c +++ b/softmmu/qemu-seccomp.c @@ -312,6 +312,19 @@ static int seccomp_start(uint32_t seccomp_opts, Error **errp) goto seccomp_return; } +#if defined(CONFIG_SECCOMP_SYSRAWRC) + /* + * This must be the first seccomp_attr_set() call to have full + * error propagation from subsequent seccomp APIs. + */ + rc = seccomp_attr_set(ctx, SCMP_FLTATR_API_SYSRAWRC, 1); + if (rc != 0) { + error_setg_errno(errp, -rc, + "failed to set seccomp rawrc attribute"); + goto seccomp_return; + } +#endif + rc = seccomp_attr_set(ctx, SCMP_FLTATR_CTL_TSYNC, 1); if (rc != 0) { error_setg_errno(errp, -rc, |