diff options
| author | Peter Maydell | 2022-07-25 16:05:16 +0200 |
|---|---|---|
| committer | Alex Bennée | 2022-07-29 10:48:01 +0200 |
| commit | 9b1268f55ceb0d9390a051cad299b3021dfa9896 (patch) | |
| tree | b98e804a30e5ab6677c062284b1af70634de01ad /softmmu | |
| parent | semihosting: Check for errors on SET_ARG() (diff) | |
| download | qemu-9b1268f55ceb0d9390a051cad299b3021dfa9896.tar.gz qemu-9b1268f55ceb0d9390a051cad299b3021dfa9896.tar.xz qemu-9b1268f55ceb0d9390a051cad299b3021dfa9896.zip | |
semihosting: Fix handling of buffer in TARGET_SYS_TMPNAM
The TARGET_SYS_TMPNAM implementation has two bugs spotted by
Coverity:
* confusion about whether 'len' has the length of the string
including or excluding the terminating NUL means we
lock_user() len bytes of memory but memcpy() len + 1 bytes
* In the error-exit cases we forget to free() the buffer
that asprintf() returned to us
Resolves: Coverity CID 1490285, 1490289
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220719121110.225657-5-peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220725140520.515340-10-alex.bennee@linaro.org>
Diffstat (limited to 'softmmu')
0 files changed, 0 insertions, 0 deletions