diff options
| author | David Hildenbrand | 2022-01-17 05:12:33 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2022-02-04 15:07:43 +0100 |
| commit | fa3d5483f0f4d4583b69ea7211c721418fca6704 (patch) | |
| tree | ca9c4fe1440d4308e385e089cd8bc6a368949cf6 /subprojects/libvhost-user | |
| parent | libvhost-user: Simplify VHOST_USER_REM_MEM_REG (diff) | |
| download | qemu-fa3d5483f0f4d4583b69ea7211c721418fca6704.tar.gz qemu-fa3d5483f0f4d4583b69ea7211c721418fca6704.tar.xz qemu-fa3d5483f0f4d4583b69ea7211c721418fca6704.zip | |
libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd
We end up not closing the file descriptor, resulting in leaking one
file descriptor for each VHOST_USER_REM_MEM_REG message.
Fixes: 875b9fd97b34 ("Support individual region unmap in libvhost-user")
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Message-Id: <20220117041050.19718-5-raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'subprojects/libvhost-user')
| -rw-r--r-- | subprojects/libvhost-user/libvhost-user.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c index 7dd8e918b4..3f4d7221ca 100644 --- a/subprojects/libvhost-user/libvhost-user.c +++ b/subprojects/libvhost-user/libvhost-user.c @@ -868,6 +868,8 @@ vu_rem_mem_reg(VuDev *dev, VhostUserMsg *vmsg) { vu_panic(dev, "Specified region not found\n"); } + close(vmsg->fds[0]); + return true; } |