summaryrefslogtreecommitdiffstats
path: root/target-i386/helper.c
diff options
context:
space:
mode:
authorJames Hogan2013-08-27 13:19:10 +0200
committerPaolo Bonzini2013-09-20 12:37:52 +0200
commit97577fd4c31777780a22b77afa4590086ac962c7 (patch)
treef564b8e5b47a84f846ef413e14e230ee67488304 /target-i386/helper.c
parentexec: always use MADV_DONTFORK (diff)
downloadqemu-97577fd4c31777780a22b77afa4590086ac962c7.tar.gz
qemu-97577fd4c31777780a22b77afa4590086ac962c7.tar.xz
qemu-97577fd4c31777780a22b77afa4590086ac962c7.zip
cpu: Move cpu state syncs up into cpu_dump_state()
The x86 and ppc targets call cpu_synchronize_state() from their *_cpu_dump_state() callbacks to ensure that up to date state is dumped when KVM is enabled (for example when a KVM internal error occurs). Move this call up into the generic cpu_dump_state() function so that other KVM targets (namely MIPS) can take advantage of it. This requires kvm_cpu_synchronize_state() and cpu_synchronize_state() to be moved out of the #ifdef NEED_CPU_H in <sysemu/kvm.h> so that they're accessible to qom/cpu.c. Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: Andreas Färber <afaerber@suse.de> Cc: Alexander Graf <agraf@suse.de> Cc: Gleb Natapov <gleb@redhat.com> Cc: qemu-ppc@nongnu.org Cc: kvm@vger.kernel.org Signed-off-by: Gleb Natapov <gleb@redhat.com>
Diffstat (limited to 'target-i386/helper.c')
-rw-r--r--target-i386/helper.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/target-i386/helper.c b/target-i386/helper.c
index 7c58e274d9..0ad7c8e3b6 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -188,8 +188,6 @@ void x86_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf,
char cc_op_name[32];
static const char *seg_name[6] = { "ES", "CS", "SS", "DS", "FS", "GS" };
- cpu_synchronize_state(cs);
-
eflags = cpu_compute_eflags(env);
#ifdef TARGET_X86_64
if (env->hflags & HF_CS64_MASK) {