diff options
| author | Eduardo Habkost | 2012-10-04 22:48:54 +0200 |
|---|---|---|
| committer | Marcelo Tosatti | 2012-10-31 02:39:46 +0100 |
| commit | 8c723b7958127b8f204dd4b278ad3c8f6f48ae17 (patch) | |
| tree | 0f91375fbc78b3674ceddde366a76b60e46fe8bc /target-i386/kvm.c | |
| parent | i386: kvm: kvm_arch_get_supported_cpuid: move R_EDX hack outside of for loop (diff) | |
| download | qemu-8c723b7958127b8f204dd4b278ad3c8f6f48ae17.tar.gz qemu-8c723b7958127b8f204dd4b278ad3c8f6f48ae17.tar.xz qemu-8c723b7958127b8f204dd4b278ad3c8f6f48ae17.zip | |
i386: kvm: kvm_arch_get_supported_cpuid: clean up has_kvm_features check
Instead of a function-specific has_kvm_features variable, simply use a
"found" variable that will be checked in case we have to use the legacy
get_para_features() interface.
No behavior change, just code cleanup.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'target-i386/kvm.c')
| -rw-r--r-- | target-i386/kvm.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/target-i386/kvm.c b/target-i386/kvm.c index b7490f92d9..56addf1866 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -130,7 +130,7 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function, int i, max; uint32_t ret = 0; uint32_t cpuid_1_edx; - int has_kvm_features = 0; + bool found = false; max = 1; while ((cpuid = try_get_cpuid(s, max)) == NULL) { @@ -140,9 +140,7 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function, for (i = 0; i < cpuid->nent; ++i) { if (cpuid->entries[i].function == function && cpuid->entries[i].index == index) { - if (cpuid->entries[i].function == KVM_CPUID_FEATURES) { - has_kvm_features = 1; - } + found = true; switch (reg) { case R_EAX: ret = cpuid->entries[i].eax; @@ -181,7 +179,7 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function, g_free(cpuid); /* fallback for older kernels */ - if (!has_kvm_features && (function == KVM_CPUID_FEATURES)) { + if ((function == KVM_CPUID_FEATURES) && !found) { ret = get_para_features(s); } |