diff options
| author | Eduardo Habkost | 2014-12-19 02:31:11 +0100 |
|---|---|---|
| committer | Eduardo Habkost | 2015-02-25 19:00:07 +0100 |
| commit | e1356dd70aef11425883dd4d2885f1d208eb9d57 (patch) | |
| tree | 8c299f0eb3dd5195ac475abf03ebbf6f39dda374 /target-i386 | |
| parent | target-i386: Set APIC ID using cpu_index on CONFIG_USER (diff) | |
| download | qemu-e1356dd70aef11425883dd4d2885f1d208eb9d57.tar.gz qemu-e1356dd70aef11425883dd4d2885f1d208eb9d57.tar.xz qemu-e1356dd70aef11425883dd4d2885f1d208eb9d57.zip | |
target-i386: Require APIC ID to be explicitly set before CPU realize
Instead of setting APIC ID automatically when creating a X86CPU, require
the property to be set before realizing the object (which all callers of
cpu_x86_create() already do).
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'target-i386')
| -rw-r--r-- | target-i386/cpu-qom.h | 2 | ||||
| -rw-r--r-- | target-i386/cpu.c | 7 |
2 files changed, 7 insertions, 2 deletions
diff --git a/target-i386/cpu-qom.h b/target-i386/cpu-qom.h index 4a6f48a8db..31a0c1e776 100644 --- a/target-i386/cpu-qom.h +++ b/target-i386/cpu-qom.h @@ -93,7 +93,7 @@ typedef struct X86CPU { bool expose_kvm; bool migratable; bool host_features; - uint32_t apic_id; + int64_t apic_id; /* if true the CPUID code directly forward host cache leaves to the guest */ bool cache_info_passthrough; diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3e0c39c8bd..54422f33ee 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2767,6 +2767,11 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) Error *local_err = NULL; static bool ht_warned; + if (cpu->apic_id < 0) { + error_setg(errp, "apic-id property was not initialized properly"); + return; + } + if (env->features[FEAT_7_0_EBX] && env->cpuid_level < 7) { env->cpuid_level = 7; } @@ -2910,7 +2915,7 @@ static void x86_cpu_initfn(Object *obj) NULL, NULL, (void *)cpu->filtered_features, NULL); cpu->hyperv_spinlock_attempts = HYPERV_SPINLOCK_NEVER_RETRY; - cpu->apic_id = x86_cpu_apic_id_from_index(cs->cpu_index); + cpu->apic_id = -1; x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort); |