diff options
| author | Amit Shah | 2012-12-12 13:56:09 +0100 |
|---|---|---|
| committer | Amit Shah | 2012-12-18 08:34:42 +0100 |
| commit | 4e28976e563ad54f6adc5ae00b1fb8224f1a82ca (patch) | |
| tree | 0ad707ebc88889f892dd51d9767fc021c4ae2185 /target-sparc/cpu.c | |
| parent | virtio-serial: delete timer if active during exit (diff) | |
| download | qemu-4e28976e563ad54f6adc5ae00b1fb8224f1a82ca.tar.gz qemu-4e28976e563ad54f6adc5ae00b1fb8224f1a82ca.tar.xz qemu-4e28976e563ad54f6adc5ae00b1fb8224f1a82ca.zip | |
virtio-serial-bus: send_control_msg() should not deal with cpkts
Stuff the cpkt before calling send_control_msg(). This function should
not be concerned about contents of the buffer it receives.
A few code refactorings recently have made making this change easier
than earlier.
Coverity and clang have flagged this code several times in the past
(cpkt->id not set before send_control_event() passed it on to
send_control_msg()). This will finally eliminate the false-positive.
CC: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Diffstat (limited to 'target-sparc/cpu.c')
0 files changed, 0 insertions, 0 deletions