diff options
| author | Peter Maydell | 2018-10-16 19:52:36 +0200 |
|---|---|---|
| committer | Peter Maydell | 2018-11-12 16:14:06 +0100 |
| commit | 435cc3e4d515591e15805b1e012564800a130b0f (patch) | |
| tree | 9a13a8c5d2bd11666b477a38b897085607bb80f7 /target/arm/internals.h | |
| parent | docker: use HTTPS git URL for virglrenderer (diff) | |
| download | qemu-435cc3e4d515591e15805b1e012564800a130b0f.tar.gz qemu-435cc3e4d515591e15805b1e012564800a130b0f.tar.xz qemu-435cc3e4d515591e15805b1e012564800a130b0f.zip | |
hw/acpi/nvdimm: Don't take address of fields in packed structs
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this. Avoid the bug by not using the
"modify in place" byte swapping functions.
Patch produced with scripts/coccinelle/inplace-byteswaps.cocci.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20181016175236.5840-1-peter.maydell@linaro.org
Diffstat (limited to 'target/arm/internals.h')
0 files changed, 0 insertions, 0 deletions