summaryrefslogtreecommitdiffstats
path: root/target/arm
diff options
context:
space:
mode:
authorPeter Maydell2019-02-01 15:55:45 +0100
committerPeter Maydell2019-02-01 15:55:45 +0100
commit4dfabb6d568e6b315594d7d464dacaf3368aff60 (patch)
tree3305acbc28ccf05be21b7750e38cc35976449483 /target/arm
parentexec.c: Don't reallocate IOMMUNotifiers that are in use (diff)
downloadqemu-4dfabb6d568e6b315594d7d464dacaf3368aff60.tar.gz
qemu-4dfabb6d568e6b315594d7d464dacaf3368aff60.tar.xz
qemu-4dfabb6d568e6b315594d7d464dacaf3368aff60.zip
target/arm/translate-a64: Fix FCMLA decoding error
The FCMLA (by element) instruction exists in the "vector x indexed element" encoding group, but not in the "scalar x indexed element" group. Correctly UNDEF the unallocated encodings. Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com> Message-id: 20190129140411.682-2-peter.maydell@linaro.org
Diffstat (limited to 'target/arm')
-rw-r--r--target/arm/translate-a64.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 07fa052393..d46ea9f64e 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -12650,7 +12650,7 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn)
case 0x13: /* FCMLA #90 */
case 0x15: /* FCMLA #180 */
case 0x17: /* FCMLA #270 */
- if (!dc_isar_feature(aa64_fcma, s)) {
+ if (is_scalar || !dc_isar_feature(aa64_fcma, s)) {
unallocated_encoding(s);
return;
}