diff options
| author | Richard Henderson | 2021-06-20 23:06:01 +0200 |
|---|---|---|
| committer | Richard Henderson | 2021-06-29 19:04:56 +0200 |
| commit | 3a1a80cc052377134a7d8c1c008085de3413cf61 (patch) | |
| tree | 74561126fec97153ebc9f08f3e8ff915a6d3a54b /target/cris | |
| parent | target/cris: Use tcg_gen_lookup_and_goto_ptr (diff) | |
| download | qemu-3a1a80cc052377134a7d8c1c008085de3413cf61.tar.gz qemu-3a1a80cc052377134a7d8c1c008085de3413cf61.tar.xz qemu-3a1a80cc052377134a7d8c1c008085de3413cf61.zip | |
target/cris: Improve JMP_INDIRECT
Use movcond instead of brcond to set env_pc.
Discard the btarget and btaken variables to improve
register allocation and avoid unnecessary writeback.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Tested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'target/cris')
| -rw-r--r-- | target/cris/translate.c | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/target/cris/translate.c b/target/cris/translate.c index 8b379522c6..1d4c78eab2 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -522,17 +522,6 @@ static void t_gen_swapr(TCGv d, TCGv s) tcg_temp_free(org_s); } -static void t_gen_cc_jmp(TCGv pc_true, TCGv pc_false) -{ - TCGLabel *l1 = gen_new_label(); - - /* Conditional jmp. */ - tcg_gen_mov_tl(env_pc, pc_false); - tcg_gen_brcondi_tl(TCG_COND_EQ, env_btaken, 0, l1); - tcg_gen_mov_tl(env_pc, pc_true); - gen_set_label(l1); -} - static bool use_goto_tb(DisasContext *dc, target_ulong dest) { return ((dest ^ dc->base.pc_first) & TARGET_PAGE_MASK) == 0; @@ -3321,8 +3310,17 @@ static void cris_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) /* fall through */ case JMP_INDIRECT: - t_gen_cc_jmp(env_btarget, tcg_constant_tl(npc)); + tcg_gen_movcond_tl(TCG_COND_NE, env_pc, + env_btaken, tcg_constant_tl(0), + env_btarget, tcg_constant_tl(npc)); is_jmp = dc->cpustate_changed ? DISAS_UPDATE : DISAS_JUMP; + + /* + * We have now consumed btaken and btarget. Hint to the + * tcg compiler that the writeback to env may be dropped. + */ + tcg_gen_discard_tl(env_btaken); + tcg_gen_discard_tl(env_btarget); break; default: |