diff options
| author | Bin Meng | 2021-06-15 10:51:33 +0200 |
|---|---|---|
| committer | Alistair Francis | 2021-06-24 14:00:12 +0200 |
| commit | 79a412891f0cb6bbffd8fd9e13608066234e56c1 (patch) | |
| tree | 92eac426b3c68a35be34977cd7cf4a90af5f5093 /target/riscv/gdbstub.c | |
| parent | target/riscv: Use target_ulong for the DisasContext misa (diff) | |
| download | qemu-79a412891f0cb6bbffd8fd9e13608066234e56c1.tar.gz qemu-79a412891f0cb6bbffd8fd9e13608066234e56c1.tar.xz qemu-79a412891f0cb6bbffd8fd9e13608066234e56c1.zip | |
target/riscv: gdbstub: Fix dynamic CSR XML generation
Since commit 605def6eeee5 ("target/riscv: Use the RISCVException enum for CSR operations")
the CSR predicate() function was changed to return RISCV_EXCP_NONE
instead of 0 for a valid CSR, but it forgot to update the dynamic
CSR XML generation codes in gdbstub.
Fixes: 605def6eeee5 ("target/riscv: Use the RISCVException enum for CSR operations")
Reported-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Tested-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20210615085133.389887-1-bmeng.cn@gmail.com
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'target/riscv/gdbstub.c')
| -rw-r--r-- | target/riscv/gdbstub.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c index ca78682cf4..a7a9c0b1fe 100644 --- a/target/riscv/gdbstub.c +++ b/target/riscv/gdbstub.c @@ -170,7 +170,7 @@ static int riscv_gen_dynamic_csr_xml(CPUState *cs, int base_reg) for (i = 0; i < CSR_TABLE_SIZE; i++) { predicate = csr_ops[i].predicate; - if (predicate && !predicate(env, i)) { + if (predicate && (predicate(env, i) == RISCV_EXCP_NONE)) { if (csr_ops[i].name) { g_string_append_printf(s, "<reg name=\"%s\"", csr_ops[i].name); } else { |