diff options
| author | Peter Xu | 2020-04-14 22:06:25 +0200 |
|---|---|---|
| committer | Alex Bennée | 2020-04-15 12:38:23 +0200 |
| commit | bbc40fefcee0d69d61ceaf8c0695d2ce43cdc87b (patch) | |
| tree | 7e30fff9c79eccf1f0fe4c2e6fcd359e5822f93c /target/xtensa/gdbstub.c | |
| parent | target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray (diff) | |
| download | qemu-bbc40fefcee0d69d61ceaf8c0695d2ce43cdc87b.tar.gz qemu-bbc40fefcee0d69d61ceaf8c0695d2ce43cdc87b.tar.xz qemu-bbc40fefcee0d69d61ceaf8c0695d2ce43cdc87b.zip | |
gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb
We should only pass in gdb_get_reg16() with the GByteArray* object
itself, no need to shift. Without this patch, gdb remote attach will
crash QEMU:
(gdb) target remote :1234
Remote debugging using :1234
Remote communication error. Target disconnected.: Connection reset by peer.
$ qemu-system-x86_64 -m 1G -smp 4 ... -s
ERROR:qemu/gdbstub.c:1843:handle_read_all_regs: assertion failed: (len == gdbserver_state.mem_buf->len)
Bail out! ERROR:qemu/gdbstub.c:1843:handle_read_all_regs: assertion failed: (len == gdbserver_state.mem_buf->len)
Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200409164954.36902-3-peterx@redhat.com>
Message-Id: <20200414200631.12799-12-alex.bennee@linaro.org>
Diffstat (limited to 'target/xtensa/gdbstub.c')
0 files changed, 0 insertions, 0 deletions