diff options
| author | Daniel Henrique Barboza | 2022-06-02 21:10:48 +0200 |
|---|---|---|
| committer | Daniel Henrique Barboza | 2022-06-20 13:38:58 +0200 |
| commit | 5980167e07bb691a36ef002a00f9e8b993f0800e (patch) | |
| tree | 47e7b63c802387b0a9d3a24967478a9993ba0105 /target | |
| parent | target/ppc: avoid int32 multiply overflow in int_helper.c (diff) | |
| download | qemu-5980167e07bb691a36ef002a00f9e8b993f0800e.tar.gz qemu-5980167e07bb691a36ef002a00f9e8b993f0800e.tar.xz qemu-5980167e07bb691a36ef002a00f9e8b993f0800e.zip | |
target/ppc: fix unreachable code in fpu_helper.c
Commit c29018cc7395 added an env->fpscr OR operation using a ternary
that checks if 'error' is not zero:
env->fpscr |= error ? FP_FEX : 0;
However, in the current body of do_fpscr_check_status(), 'error' is
granted to be always non-zero at that point. The result is that Coverity
is less than pleased:
Control flow issues (DEADCODE)
Execution cannot reach the expression "0ULL" inside this statement:
"env->fpscr |= (error ? 1073...".
Remove the ternary and always make env->fpscr |= FP_FEX.
Cc: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
Cc: Richard Henderson <richard.henderson@linaro.org>
Fixes: Coverity CID 1489442
Fixes: c29018cc7395 ("target/ppc: Implemented xvf*ger*")
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
Message-Id: <20220602191048.137511-1-danielhb413@gmail.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Diffstat (limited to 'target')
| -rw-r--r-- | target/ppc/fpu_helper.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index fed0ce420a..7ab6beadad 100644 --- a/target/ppc/fpu_helper.c +++ b/target/ppc/fpu_helper.c @@ -464,7 +464,7 @@ static void do_fpscr_check_status(CPUPPCState *env, uintptr_t raddr) } cs->exception_index = POWERPC_EXCP_PROGRAM; env->error_code = error | POWERPC_EXCP_FP; - env->fpscr |= error ? FP_FEX : 0; + env->fpscr |= FP_FEX; /* Deferred floating-point exception after target FPSCR update */ if (fp_exceptions_enabled(env)) { raise_exception_err_ra(env, cs->exception_index, |