diff options
| author | Peter Maydell | 2017-07-20 18:31:30 +0200 |
|---|---|---|
| committer | Peter Maydell | 2017-07-21 11:32:41 +0200 |
| commit | 95a5befc2f8b359e72926f89cd661d063c2cf06c (patch) | |
| tree | 6589dd6adba5d123145be8e25e29e1bd0a8e69aa /target | |
| parent | util/oslib-posix.c: Avoid warning on NetBSD (diff) | |
| download | qemu-95a5befc2f8b359e72926f89cd661d063c2cf06c.tar.gz qemu-95a5befc2f8b359e72926f89cd661d063c2cf06c.tar.xz qemu-95a5befc2f8b359e72926f89cd661d063c2cf06c.zip | |
Use qemu_tolower() and qemu_toupper(), not tolower() and toupper()
On NetBSD, where tolower() and toupper() are implemented using an
array lookup, the compiler warns if you pass a plain 'char'
to these functions:
gdbstub.c:914:13: warning: array subscript has type 'char'
This reflects the fact that toupper() and tolower() give
undefined behaviour if they are passed a value that isn't
a valid 'unsigned char' or EOF.
We have qemu_tolower() and qemu_toupper() to avoid this problem;
use them.
(The use in scsi-generic.c does not trigger the warning because
it passes a uint8_t; we switch it anyway, for consistency.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> for the s390 part.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-id: 1500568290-7966-1-git-send-email-peter.maydell@linaro.org
Diffstat (limited to 'target')
| -rw-r--r-- | target/ppc/monitor.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/ppc/monitor.c b/target/ppc/monitor.c index b8f30e9eaf..14915119fc 100644 --- a/target/ppc/monitor.c +++ b/target/ppc/monitor.c @@ -115,14 +115,14 @@ int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval) CPUPPCState *env = &cpu->env; /* General purpose registers */ - if ((tolower(name[0]) == 'r') && + if ((qemu_tolower(name[0]) == 'r') && ppc_cpu_get_reg_num(name + 1, ARRAY_SIZE(env->gpr), ®num)) { *pval = env->gpr[regnum]; return 0; } /* Floating point registers */ - if ((tolower(name[0]) == 'f') && + if ((qemu_tolower(name[0]) == 'f') && ppc_cpu_get_reg_num(name + 1, ARRAY_SIZE(env->fpr), ®num)) { *pval = env->fpr[regnum]; return 0; |