diff options
| author | Alex Bennée | 2021-01-05 13:44:05 +0100 |
|---|---|---|
| committer | Alex Bennée | 2021-01-06 18:30:02 +0100 |
| commit | 93eaabde61cf048660a01dc2b5f55c061fd73e6b (patch) | |
| tree | efb3b9abdd2a4595880cc1776da11e2af93c364a /tests/acceptance | |
| parent | tests/iotests: drop test 312 from auto group (diff) | |
| download | qemu-93eaabde61cf048660a01dc2b5f55c061fd73e6b.tar.gz qemu-93eaabde61cf048660a01dc2b5f55c061fd73e6b.tar.xz qemu-93eaabde61cf048660a01dc2b5f55c061fd73e6b.zip | |
tests/acceptance: bound the size of readline in s390_ccw_virtio
The read binary data as text via a PPM export of the frame buffer
seems a bit sketchy and it did blow up in the real world when the
assertion failed:
https://gitlab.com/qemu-project/qemu/-/jobs/943183183
However short of cleaning up the test to be more binary focused at
least limit the attempt to dump the whole file as hexified zeros in
the logs.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210105124405.15424-1-alex.bennee@linaro.org>
Diffstat (limited to 'tests/acceptance')
| -rw-r--r-- | tests/acceptance/machine_s390_ccw_virtio.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py index 0f81af9950..eccf26b262 100644 --- a/tests/acceptance/machine_s390_ccw_virtio.py +++ b/tests/acceptance/machine_s390_ccw_virtio.py @@ -241,7 +241,7 @@ class S390CCWVirtioMachine(Test): self.assertEqual(line, b"1024 768\n") line = ppmfile.readline() self.assertEqual(line, b"255\n") - line = ppmfile.readline() + line = ppmfile.readline(256) self.assertEqual(line, b"The quick fox jumps over a lazy dog\n") # Hot-plug a virtio-crypto device and see whether it gets accepted |