diff options
| author | Daniel P. Berrangé | 2019-02-11 19:24:31 +0100 |
|---|---|---|
| committer | Marc-André Lureau | 2019-02-12 17:35:56 +0100 |
| commit | 767abe7f49e8be14d29da5db3527817b5d696a52 (patch) | |
| tree | 726740effc4c442b56a8370ee37a708c8dfdddd8 /tests/ivshmem-test.c | |
| parent | chardev: forbid 'reconnect' option with server sockets (diff) | |
| download | qemu-767abe7f49e8be14d29da5db3527817b5d696a52.tar.gz qemu-767abe7f49e8be14d29da5db3527817b5d696a52.tar.xz qemu-767abe7f49e8be14d29da5db3527817b5d696a52.zip | |
chardev: forbid 'wait' option with client sockets
The 'wait'/'nowait' parameter is used to tell server sockets whether to
block until a client is accepted during initialization. Client chardevs
have always silently ignored this option. Various tests were mistakenly
passing this option for their client chardevs.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20190211182442.8542-6-berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Diffstat (limited to 'tests/ivshmem-test.c')
| -rw-r--r-- | tests/ivshmem-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c index 4911b69317..942ddc9192 100644 --- a/tests/ivshmem-test.c +++ b/tests/ivshmem-test.c @@ -295,7 +295,7 @@ static void setup_vm_with_server(IVState *s, int nvectors) { char *cmd; - cmd = g_strdup_printf("-chardev socket,id=chr0,path=%s,nowait " + cmd = g_strdup_printf("-chardev socket,id=chr0,path=%s " "-device ivshmem-doorbell,chardev=chr0,vectors=%d", tmpserver, nvectors); |