diff options
| author | Markus Armbruster | 2019-09-14 17:34:59 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2019-09-24 14:07:23 +0200 |
| commit | dec0012ef8d644b5dde1b68ee8dab3f8c12e0b6b (patch) | |
| tree | 61c6ab6e7f0576311d94783c99045f117c73e14f /tests/qapi-schema/union-branch-if-invalid.json | |
| parent | qapi: Reject blank 'if' conditions in addition to empty ones (diff) | |
| download | qemu-dec0012ef8d644b5dde1b68ee8dab3f8c12e0b6b.tar.gz qemu-dec0012ef8d644b5dde1b68ee8dab3f8c12e0b6b.tar.xz qemu-dec0012ef8d644b5dde1b68ee8dab3f8c12e0b6b.zip | |
qapi: Fix missing 'if' checks in struct, union, alternate 'data'
Commit 87adbbffd4..3e270dcacc "qapi: Add 'if' to (implicit
struct|union|alternate) members" (v4.0.0) neglected test coverage, and
promptly failed to check the conditions. Review fail.
Recent commit "tests/qapi-schema: Demonstrate insufficient 'if'
checking" added test coverage, demonstrating the bug. Fix it by add
the missing check_if().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190914153506.2151-13-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'tests/qapi-schema/union-branch-if-invalid.json')
| -rw-r--r-- | tests/qapi-schema/union-branch-if-invalid.json | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/qapi-schema/union-branch-if-invalid.json b/tests/qapi-schema/union-branch-if-invalid.json index 859b63b610..46d4239af6 100644 --- a/tests/qapi-schema/union-branch-if-invalid.json +++ b/tests/qapi-schema/union-branch-if-invalid.json @@ -1,5 +1,4 @@ # Cover branch with invalid 'if' -# FIXME not rejected, would generate '#if \n' { 'enum': 'Branches', 'data': ['branch1'] } { 'struct': 'Stru', 'data': { 'member': 'str' } } { 'union': 'Uni', |