diff options
| author | Eric Blake | 2015-11-18 09:52:55 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2015-12-17 08:21:27 +0100 |
| commit | 5be5b7764f83cf9a535a22ecbd33710daf1fe210 (patch) | |
| tree | 094248f844892ea5db23bbda9eb7ddc7cf1921ee /tests/qemu-iotests/026 | |
| parent | blkdebug: Merge hand-rolled and qapi BlkdebugEvent enum (diff) | |
| download | qemu-5be5b7764f83cf9a535a22ecbd33710daf1fe210.tar.gz qemu-5be5b7764f83cf9a535a22ecbd33710daf1fe210.tar.xz qemu-5be5b7764f83cf9a535a22ecbd33710daf1fe210.zip | |
blkdebug: Avoid '.' in enum values
Our qapi conventions document that '.' should only be used in
the prefix of downstream names. BlkdebugEvent was a lone
exception to this. Changing this is not backwards compatible
to the 'blockdev-add' QMP command; however, that command is
not yet fully stable. It can also be argued that the testsuite
is the biggest user of blkdebug, and that any other user can
be taught to deal with the change by paying attention to
introspection results.
Done with:
$ for str in \
l1_grow.{alloc,write,activate}_table \
l2_alloc.{cow_read,write} \
refblock_alloc.{hookup,write,write_blocks,write_table,switch_table} \
pwritev_rmw.{head,after_head,tail,after_tail}; do
str1=$(echo "$str" | sed 's/\./\\./')
str2=$(echo "$str" | sed 's/\./_/')
git grep -l "$str1" | xargs -r sed -i "s/$str1/$str2/g"
done
followed by a manual touchup to test 77 to keep the test working.
Reported-by: Markus Armbruster <armbru@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1447836791-369-21-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/026')
| -rwxr-xr-x | tests/qemu-iotests/026 | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/tests/qemu-iotests/026 b/tests/qemu-iotests/026 index 0fc3244c7f..ba1047c96a 100755 --- a/tests/qemu-iotests/026 +++ b/tests/qemu-iotests/026 @@ -66,7 +66,7 @@ for event in \ \ l2_load \ l2_update \ - l2_alloc.write \ + l2_alloc_write \ \ write_aio \ \ @@ -126,11 +126,11 @@ CLUSTER_SIZE=512 for event in \ - refblock_alloc.hookup \ - refblock_alloc.write \ - refblock_alloc.write_blocks \ - refblock_alloc.write_table \ - refblock_alloc.switch_table \ + refblock_alloc_hookup \ + refblock_alloc_write \ + refblock_alloc_write_blocks \ + refblock_alloc_write_table \ + refblock_alloc_switch_table \ do @@ -170,9 +170,9 @@ CLUSTER_SIZE=1024 for event in \ - l1_grow.alloc_table \ - l1_grow.write_table \ - l1_grow.activate_table \ + l1_grow_alloc_table \ + l1_grow_write_table \ + l1_grow_activate_table \ do |