diff options
author | Eric Blake | 2018-11-16 22:50:02 +0100 |
---|---|---|
committer | Eric Blake | 2018-11-19 18:16:46 +0100 |
commit | 8cedcffdc195bc39aeb1373826ba0a45629741e0 (patch) | |
tree | 46509d211d6dcf12f6d2923e9a37a1667177f762 /tests/qemu-iotests/099 | |
parent | iotests: Also test I/O over NBD TLS (diff) | |
download | qemu-8cedcffdc195bc39aeb1373826ba0a45629741e0.tar.gz qemu-8cedcffdc195bc39aeb1373826ba0a45629741e0.tar.xz qemu-8cedcffdc195bc39aeb1373826ba0a45629741e0.zip |
iotests: Drop use of bash keyword 'function'
Bash allows functions to be declared with or without the leading
keyword 'function'; but including the keyword does not comply with
POSIX syntax, and is confusing to ksh users where the use of the
keyword changes the scoping rules for functions. Stick to the
POSIX form through iotests.
Done mechanically with:
sed -i 's/^function //' $(git ls-files tests/qemu-iotests)
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181116215002.2124581-1-eblake@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/099')
-rwxr-xr-x | tests/qemu-iotests/099 | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/qemu-iotests/099 b/tests/qemu-iotests/099 index 4a6275d4bc..578808b747 100755 --- a/tests/qemu-iotests/099 +++ b/tests/qemu-iotests/099 @@ -45,12 +45,12 @@ _supported_os Linux _unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat" \ "subformat=twoGbMaxExtentSparse" -function do_run_qemu() +do_run_qemu() { $QEMU -nographic -qmp stdio -serial none "$@" } -function run_qemu() +run_qemu() { # Get the "file": "foo" entry ($foo may only contain escaped double quotes, # which is how we can extract it) @@ -59,7 +59,7 @@ function run_qemu() | sed -e 's/^.*"file": "\(\(\\"\|[^"]\)*\)".*$/\1/' -e 's/\\"/"/g' } -function test_qemu() +test_qemu() { run_qemu -drive "if=none,id=drv0,$1" <<EOF { 'execute': 'qmp_capabilities' } |