diff options
| author | John Snow | 2018-07-10 19:00:40 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2018-07-12 18:24:08 +0200 |
| commit | 230ff73904e72dde2d7718c2da407786a1c72e57 (patch) | |
| tree | 04a8bf0cfe28d25482a65e64446f8b4c35c0204f /tests/qemu-iotests | |
| parent | qemu-img: Document copy offloading implications with -S and -c (diff) | |
| download | qemu-230ff73904e72dde2d7718c2da407786a1c72e57.tar.gz qemu-230ff73904e72dde2d7718c2da407786a1c72e57.tar.xz qemu-230ff73904e72dde2d7718c2da407786a1c72e57.zip | |
file-posix: specify expected filetypes
Adjust each caller of raw_open_common to specify if they are expecting
host and character devices or not. Tighten expectations of file types upon
open in the common code and refuse types that are not expected.
This has two effects:
(1) Character and block devices are now considered deprecated for the
'file' driver, which expects only S_IFREG, and
(2) no file-posix driver (file, host_cdrom, or host_device) can open
directories now.
I don't think there's a legitimate reason to open directories as if
they were files. This prevents QEMU from opening and attempting to probe
a directory inode, which can break in exciting ways. One of those ways
is lseek on ext4/xfs, which will return 0x7fffffffffffffff as the file
size instead of EISDIR. This can coax QEMU into responding with a
confusing "file too big" instead of "Hey, that's not a file".
See: https://bugs.launchpad.net/qemu/+bug/1739304/
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'tests/qemu-iotests')
0 files changed, 0 insertions, 0 deletions