diff options
| author | Alex Bennée | 2022-08-02 11:50:07 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2022-10-07 15:41:51 +0200 |
| commit | 3bd869f36e3bec51969c8cdb0e3637312d85eb1b (patch) | |
| tree | 4a851c7e6cdb546b81a6103a2d4b32a3cb929360 /tests/qtest/libqos | |
| parent | tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES (diff) | |
| download | qemu-3bd869f36e3bec51969c8cdb0e3637312d85eb1b.tar.gz qemu-3bd869f36e3bec51969c8cdb0e3637312d85eb1b.tar.xz qemu-3bd869f36e3bec51969c8cdb0e3637312d85eb1b.zip | |
tests/qtest: add assert to catch bad features
No device driver (which is what the qvirtio_ access functions
represent) should be setting UNUSED(30) in the feature space. Although
existing libqos users mask it out lets ensure nothing sneaks through.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220802095010.3330793-20-alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'tests/qtest/libqos')
| -rw-r--r-- | tests/qtest/libqos/virtio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c index 09ec09b655..03056e5187 100644 --- a/tests/qtest/libqos/virtio.c +++ b/tests/qtest/libqos/virtio.c @@ -101,6 +101,8 @@ uint64_t qvirtio_get_features(QVirtioDevice *d) void qvirtio_set_features(QVirtioDevice *d, uint64_t features) { + g_assert(!(features & QVIRTIO_F_BAD_FEATURE)); + d->features = features; d->bus->set_features(d, features); |