summaryrefslogtreecommitdiffstats
path: root/tests/qtest
diff options
context:
space:
mode:
authorDaniel P. Berrangé2022-03-10 18:18:07 +0100
committerDr. David Alan Gilbert2022-04-21 20:36:46 +0200
commit0c2b6c85c99d8d2a957e6637c7cc0fd33f2b0540 (patch)
tree5614402f4028ba35682f66511a072344ed3bc973 /tests/qtest
parenttests: support QTEST_TRACE env variable (diff)
downloadqemu-0c2b6c85c99d8d2a957e6637c7cc0fd33f2b0540.tar.gz
qemu-0c2b6c85c99d8d2a957e6637c7cc0fd33f2b0540.tar.xz
qemu-0c2b6c85c99d8d2a957e6637c7cc0fd33f2b0540.zip
tests: print newline after QMP response in qtest logs
The QMP commands have a trailing newline, but the response does not. This makes the qtest logs hard to follow as the next QMP command appears in the same line as the previous QMP response. Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Message-Id: <20220310171821.3724080-5-berrange@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'tests/qtest')
-rw-r--r--tests/qtest/libqtest.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7db7ef3a68..5098d71485 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -612,10 +612,13 @@ QDict *qmp_fd_receive(int fd)
}
if (log) {
- len = write(2, &c, 1);
+ g_assert(write(2, &c, 1) == 1);
}
json_message_parser_feed(&qmp.parser, &c, 1);
}
+ if (log) {
+ g_assert(write(2, "\n", 1) == 1);
+ }
json_message_parser_destroy(&qmp.parser);
return qmp.response;