diff options
author | Eric Blake | 2017-11-08 22:57:01 +0100 |
---|---|---|
committer | Eric Blake | 2017-11-09 17:18:31 +0100 |
commit | 9d8f818cdee83e726a5dd14b645738ec632d2577 (patch) | |
tree | ee6c174062d82a05b12b67515223582d3a460ed4 /tests/test-aio-multithread.c | |
parent | nbd: Fix struct name for structured reads (diff) | |
download | qemu-9d8f818cdee83e726a5dd14b645738ec632d2577.tar.gz qemu-9d8f818cdee83e726a5dd14b645738ec632d2577.tar.xz qemu-9d8f818cdee83e726a5dd14b645738ec632d2577.zip |
nbd-client: Short-circuit 0-length operations
The NBD spec was recently clarified to state that clients should
not send 0-length requests to the server, as the server behavior
is undefined [1]. We know that qemu-nbd's behavior is a successful
no-op (once it has filtered for read-only exports), but other NBD
implementations might return an error. To avoid any questionable
server implementations, it is better to just short-circuit such
requests on the client side (we are relying on the block layer to
already filter out requests such as invalid offset, write to a
read-only volume, and so forth); do the short-circuit as late as
possible to still benefit from protections from assertions that
the block layer is not violating our assumptions.
[1] https://github.com/NetworkBlockDevice/nbd/commit/ee926037
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20171108215703.9295-6-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Diffstat (limited to 'tests/test-aio-multithread.c')
0 files changed, 0 insertions, 0 deletions