diff options
| author | Emilio G. Cota | 2016-07-25 17:03:45 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2016-08-03 18:44:56 +0200 |
| commit | 11b7b07f8a15879134a54e73fade98d5e11e04f8 (patch) | |
| tree | f3ca6774ea7b23a2fb01ed45874d4f375fb10da4 /tests | |
| parent | qdist: use g_renew and g_new instead of g_realloc and g_malloc. (diff) | |
| download | qemu-11b7b07f8a15879134a54e73fade98d5e11e04f8.tar.gz qemu-11b7b07f8a15879134a54e73fade98d5e11e04f8.tar.xz qemu-11b7b07f8a15879134a54e73fade98d5e11e04f8.zip | |
qdist: return "(empty)" instead of NULL when printing an empty dist
Printf'ing a NULL string is undefined behaviour. Avoid it.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Message-Id: <1469459025-23606-4-git-send-email-cota@braap.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-qdist.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/tests/test-qdist.c b/tests/test-qdist.c index 0298986ac9..9541ce31eb 100644 --- a/tests/test-qdist.c +++ b/tests/test-qdist.c @@ -360,10 +360,16 @@ static void test_none(void) g_assert(isnan(qdist_xmax(&dist))); pr = qdist_pr_plain(&dist, 0); - g_assert(pr == NULL); + g_assert_cmpstr(pr, ==, "(empty)"); + g_free(pr); pr = qdist_pr_plain(&dist, 2); - g_assert(pr == NULL); + g_assert_cmpstr(pr, ==, "(empty)"); + g_free(pr); + + pr = qdist_pr(&dist, 0, QDIST_PR_BORDER); + g_assert_cmpstr(pr, ==, "(empty)"); + g_free(pr); qdist_destroy(&dist); } |