diff options
| author | Peter Delevoryas | 2022-07-14 16:24:38 +0200 |
|---|---|---|
| committer | Cédric Le Goater | 2022-07-14 16:24:38 +0200 |
| commit | 1f30db922c72ca8c9de31f58a996bc21ee668304 (patch) | |
| tree | 56a0c9dcbd967482721c75c75b9bc09ba84769b9 /tests | |
| parent | qtest/aspeed_gpio: Add input pin modification test (diff) | |
| download | qemu-1f30db922c72ca8c9de31f58a996bc21ee668304.tar.gz qemu-1f30db922c72ca8c9de31f58a996bc21ee668304.tar.xz qemu-1f30db922c72ca8c9de31f58a996bc21ee668304.zip | |
hw/gpio/aspeed: Don't let guests modify input pins
Up until now, guests could modify input pins by overwriting the data
value register. The guest OS should only be allowed to modify output pin
values, and the QOM property setter should only be permitted to modify
input pins.
This change also updates the gpio input pin test to match this
expectation.
Andrew suggested this particularly refactoring here:
https://lore.kernel.org/qemu-devel/23523aa1-ba81-412b-92cc-8174faba3612@www.fastmail.com/
Suggested-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Peter Delevoryas <peter@pjd.dev>
Fixes: 4b7f956862dc ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500")
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220712023219.41065-3-peter@pjd.dev>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qtest/aspeed_gpio-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qtest/aspeed_gpio-test.c b/tests/qtest/aspeed_gpio-test.c index 8f52454099..d38f51d719 100644 --- a/tests/qtest/aspeed_gpio-test.c +++ b/tests/qtest/aspeed_gpio-test.c @@ -69,7 +69,7 @@ static void test_set_input_pins(const void *data) qtest_writel(s, AST2600_GPIO_BASE + GPIO_ABCD_DATA_VALUE, 0x00000000); value = qtest_readl(s, AST2600_GPIO_BASE + GPIO_ABCD_DATA_VALUE); - g_assert_cmphex(value, ==, 0x00000000); + g_assert_cmphex(value, ==, 0xffffffff); } int main(int argc, char **argv) |