diff options
| author | Marc-André Lureau | 2017-08-25 12:59:10 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2017-09-04 13:09:12 +0200 |
| commit | 6da8a7a3b444211914418d2b3c7dc615d70a7d2d (patch) | |
| tree | 0788324a9fef5a6ab54776affd1ae5fac674bd97 /tests | |
| parent | tests/check-qlit: New, covering qobject/qlit.c (diff) | |
| download | qemu-6da8a7a3b444211914418d2b3c7dc615d70a7d2d.tar.gz qemu-6da8a7a3b444211914418d2b3c7dc615d70a7d2d.tar.xz qemu-6da8a7a3b444211914418d2b3c7dc615d70a7d2d.zip | |
qlit: Tighten QLit dict vs QDict comparison
We check that all members of the QLit dictionary are also in the
QDict. We neglect to check the other direction.
Comparing the number of members suffices, because QDict can't
contain duplicate members, and putting duplicates in a QLit is a
programming error.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20170825105913.4060-12-marcandre.lureau@redhat.com>
[Commit message improved]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/check-qlit.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tests/check-qlit.c b/tests/check-qlit.c index d2422bbaf0..d2ecc200d3 100644 --- a/tests/check-qlit.c +++ b/tests/check-qlit.c @@ -28,6 +28,11 @@ static QLitObject qlit = QLIT_QDICT(((QLitDictEntry[]) { { }, })); +static QLitObject qlit_foo = QLIT_QDICT(((QLitDictEntry[]) { + { "foo", QLIT_QNUM(42) }, + { }, +})); + static QObject *make_qobject(void) { QDict *qdict = qdict_new(); @@ -51,6 +56,8 @@ static void qlit_equal_qobject_test(void) g_assert(qlit_equal_qobject(&qlit, qobj)); + g_assert(!qlit_equal_qobject(&qlit_foo, qobj)); + qobject_decref(qobj); } |