diff options
| author | Peter Maydell | 2021-05-25 15:44:56 +0200 |
|---|---|---|
| committer | Peter Maydell | 2021-06-03 17:43:27 +0200 |
| commit | 909e4a0826cde069555d90a9797590c5988d9b7e (patch) | |
| tree | 0d206be5c0cea96b0e1da01156117d720c20cb88 /tests | |
| parent | tests/qtest/hd-geo-test: Fix checks on mkstemp() return value (diff) | |
| download | qemu-909e4a0826cde069555d90a9797590c5988d9b7e.tar.gz qemu-909e4a0826cde069555d90a9797590c5988d9b7e.tar.xz qemu-909e4a0826cde069555d90a9797590c5988d9b7e.zip | |
tests/qtest/pflash-cfi02-test: Avoid potential integer overflow
Coverity points out that we calculate a 64-bit value using 32-bit
arithmetic; add the cast to force the multiply to be done as 64-bits.
(The overflow will never happen with the current test data.)
Fixes: Coverity CID 1432320
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Message-id: 20210525134458.6675-5-peter.maydell@linaro.org
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qtest/pflash-cfi02-test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qtest/pflash-cfi02-test.c b/tests/qtest/pflash-cfi02-test.c index 60db81a3a2..6168edc821 100644 --- a/tests/qtest/pflash-cfi02-test.c +++ b/tests/qtest/pflash-cfi02-test.c @@ -406,7 +406,7 @@ static void test_geometry(const void *opaque) for (int region = 0; region < nb_erase_regions; ++region) { for (uint32_t i = 0; i < c->nb_blocs[region]; ++i) { - uint64_t byte_addr = i * c->sector_len[region]; + uint64_t byte_addr = (uint64_t)i * c->sector_len[region]; g_assert_cmphex(flash_read(c, byte_addr), ==, bank_mask(c)); } } |