diff options
| author | Stefan Hajnoczi | 2017-03-01 12:50:25 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2017-04-21 11:36:12 +0200 |
| commit | ab08aec45f67a776ea37cee0bf94a34abb84ad97 (patch) | |
| tree | a26d2c99a50a7399609dfd08696b39283e10e0d9 /tests | |
| parent | qemu-options: explain disk I/O throttling options (diff) | |
| download | qemu-ab08aec45f67a776ea37cee0bf94a34abb84ad97.tar.gz qemu-ab08aec45f67a776ea37cee0bf94a34abb84ad97.tar.xz qemu-ab08aec45f67a776ea37cee0bf94a34abb84ad97.zip | |
throttle: do not use invalid config in test
The (burst) max parameter cannot be smaller than the avg parameter.
There is a test case that uses avg = 56, max = 1 and gets away with it
because no input validation is performed by the test case.
This patch switches to valid test input parameters.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 20170301115026.22621-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test-throttle.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/test-throttle.c b/tests/test-throttle.c index bd7c501b2e..089e937356 100644 --- a/tests/test-throttle.c +++ b/tests/test-throttle.c @@ -205,8 +205,8 @@ static void test_config_functions(void) orig_cfg.buckets[THROTTLE_OPS_READ].avg = 69; orig_cfg.buckets[THROTTLE_OPS_WRITE].avg = 23; - orig_cfg.buckets[THROTTLE_BPS_TOTAL].max = 0; /* should be corrected */ - orig_cfg.buckets[THROTTLE_BPS_READ].max = 1; /* should not be corrected */ + orig_cfg.buckets[THROTTLE_BPS_TOTAL].max = 0; /* should be corrected */ + orig_cfg.buckets[THROTTLE_BPS_READ].max = 56; /* should not be corrected */ orig_cfg.buckets[THROTTLE_BPS_WRITE].max = 120; orig_cfg.buckets[THROTTLE_OPS_TOTAL].max = 150; @@ -246,8 +246,8 @@ static void test_config_functions(void) g_assert(final_cfg.buckets[THROTTLE_OPS_READ].avg == 69); g_assert(final_cfg.buckets[THROTTLE_OPS_WRITE].avg == 23); - g_assert(final_cfg.buckets[THROTTLE_BPS_TOTAL].max == 15.3);/* fixed */ - g_assert(final_cfg.buckets[THROTTLE_BPS_READ].max == 1); /* not fixed */ + g_assert(final_cfg.buckets[THROTTLE_BPS_TOTAL].max == 15.3); /* fixed */ + g_assert(final_cfg.buckets[THROTTLE_BPS_READ].max == 56); /* not fixed */ g_assert(final_cfg.buckets[THROTTLE_BPS_WRITE].max == 120); g_assert(final_cfg.buckets[THROTTLE_OPS_TOTAL].max == 150); |